Skip to content

Commit

Permalink
Refs #19743: [ARS] Improve StatusLayout.qml comments
Browse files Browse the repository at this point in the history
Signed-off-by: JesusPoderoso <[email protected]>
  • Loading branch information
JesusPoderoso committed Nov 13, 2023
1 parent 5620d09 commit 737cfc0
Showing 1 changed file with 20 additions and 3 deletions.
23 changes: 20 additions & 3 deletions qml/StatusLayout.qml
Original file line number Diff line number Diff line change
Expand Up @@ -56,30 +56,34 @@ Item
property int firstIndentation: 5
property int secondIndentation: firstIndentation + iconSize + spacingIconLabel


// Main tab view with possibility of multiple tabs
TabView {
id: tab_view
anchors.top: parent.top
anchors.bottom: separator_line.top
width: parent.width

// Main Problems tab
Tab {
title: "Problems"
Rectangle {

color: "white"

// Main content of problems tab: problem tree view with problems per entity
StatusTreeView {
id: status_tree_view
anchors.fill: parent
anchors.margins: 1

model: entityStatusModel
model: entityStatusModel // problems model: entity status proxy model

// display if hidden when problems filtered (from right-click dialog)
onEntity_status_filtered:{
collapse_status_layout()
}

// filter and clean filter signal-slots management
Connections {
target: statusLayout

Expand All @@ -94,8 +98,11 @@ Item
}
}
}

// Tab main stlye
style: TabViewStyle {
frameOverlap: 1
// Each tab style: simple rounded rect header with text
tab: Rectangle {
color: styleData.selected ? "white" : Theme.lightGrey
implicitWidth: Math.max(text.width + 10, tabs_width_)
Expand All @@ -115,12 +122,15 @@ Item
text: styleData.title
}
}
// Tab bar style: would contain all tabs, and the custom menu on the right section
// (close, expand/collapse, and filter buttons, from right to left)
tabBar: Rectangle {
anchors.top: parent.top
width: parent.width
height: tabs_height_
color: grey_background_

// Close button
IconSVG {
id: close_icon
anchors.right: parent.right
Expand All @@ -140,6 +150,7 @@ Item
}
}

// Container with expand and collapse buttons
Rectangle {
id: rect
anchors.right: close_icon.left
Expand Down Expand Up @@ -178,6 +189,7 @@ Item
}
}

// Container with filter buttons (filtered/not filtered icons)
Rectangle {
id: filter_rect
anchors.right: rect.left
Expand Down Expand Up @@ -210,6 +222,7 @@ Item
}
}

// connections to update filter icons
Connections {
target: statusLayout

Expand All @@ -234,14 +247,18 @@ Item
color: Theme.grey
}

// footer (and ALWAYS displayed) error and warning counters bar section
Rectangle {
id: icon_section
anchors.bottom: parent.bottom
height: footer_height
width: parent.width
color: grey_background_

Component.onCompleted: { close_status_layout() }
// Close status so only this section is displayed, when component is loaded
Component.onCompleted: {
close_status_layout()
}

IconSVG {
id: error_icon
Expand Down

0 comments on commit 737cfc0

Please sign in to comment.