Refs #19973: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>
eProsima · Nov 24, 2023 · 3f1d743 · 3f1d743
1 parent b8e9a18
commit 3f1d743
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/qml/DomainGraphLayout.qml b/qml/DomainGraphLayout.qml
@@ -35,6 +35,7 @@ Item
     signal update_tab_name(string new_name, string stack_id)  // Update tab name based on selected domain id
     signal openEntitiesMenu(string domainEntityId, string entityId, string currentAlias, string entityKind)
     signal openTopicMenu(string domainEntityId, string domainId, string entityId, string currentAlias, string entityKind)
+    signal openLoadingGraphDialog()                     //l et tab layout know that graph is about to be generated
     signal initialized()                                // let tab layout know that graph has been generated
 
     // Private properties
@@ -1322,6 +1323,7 @@ Item
             text: "Refresh"
 
             onClicked:{
+                domainGraphLayout.openLoadingGraphDialog()
                 load_model()
             }
         }

diff --git a/qml/GraphConnection.qml b/qml/GraphConnection.qml
@@ -141,7 +141,7 @@ Item {
         Rectangle {
             id: spot_0
             anchors.verticalCenter: parent.verticalCenter
-            anchors.right: spot_1.left; anchors.rightMargin: hidden_arrow_margin_*2-graphConnection.height/2
+            anchors.right: spot_1.left; anchors.rightMargin: hidden_arrow_margin_*2-graphConnection.height/2 +1
             height: graphConnection.height; width: graphConnection.height
             radius: graphConnection.height
             color: arrow_color

diff --git a/qml/TabLayout.qml b/qml/TabLayout.qml
@@ -36,7 +36,8 @@ Item {
     property int last_index_: 1                                             // force unique idx on QML components
     property var tab_model_: [{"idx":0, "title":"New Tab", "stack_id": 0}]  // tab model for tab bad and tab management
     property bool disable_chart_selection_: false                           // flag to disable multiple chart view tabs
-    readonly property var allowed_stack_components_: ["view_selector", "chartsLayout", "domainGraphLayout_component"]
+    readonly property var allowed_stack_components_:                        // list of allowed component names to be
+            ["view_selector", "chartsLayout", "domainGraphLayout_component"]//  loaded in the tabs stack view
 
     // private signals
     signal open_domain_view_(int stack_id, int entity_id, int domain_id)
@@ -247,6 +248,10 @@ Item {
                             tabLayout.openTopicMenu(domainEntityId, domainId, entityId, currentAlias, entityKind)
                         }
 
+                        onOpenLoadingGraphDialog: {
+                            loading_graph_dialog.open()
+                        }
+
                         onInitialized: {
                             loading_graph_dialog.soft_close()
                         }