Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13740] Add afunction that checks for repeated -I paths (issue #78) #429

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

juanjo4936
Copy link
Contributor

@juanjo4936 juanjo4936 commented Jan 8, 2025

Description

Added a function that checks if the paths included with the -I function have already been added, and skips them if so. This solves issue #78, and was suggested by the original author. I had to update a couple of terms to the new notation, so we should be careful with backports.

@Mergifyio backport 3.3.x 2.5.x 2.1.x

Fixes #78

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanjo4936 juanjo4936 added this to the v4.0.4 milestone Jan 8, 2025
@juanjo4936 juanjo4936 added the ci-pending PR which CI is running label Jan 8, 2025
@MiguelCompany MiguelCompany merged commit 5f95b79 into master Jan 10, 2025
4 checks passed
@MiguelCompany MiguelCompany deleted the fix/double_include_hang branch January 10, 2025 11:03
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.3.x 2.5.x 2.1.x

Copy link

mergify bot commented Jan 10, 2025

backport 3.3.x 2.5.x 2.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 10, 2025
Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 5f95b79)

# Conflicts:
#	src/main/java/com/eprosima/fastdds/fastddsgen.java
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 5f95b79)

# Conflicts:
#	src/main/java/com/eprosima/fastdds/fastddsgen.java
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 5f95b79)

# Conflicts:
#	src/main/java/com/eprosima/fastdds/fastddsgen.java
EugenioCollado pushed a commit that referenced this pull request Jan 16, 2025
* Refs #13740: Solved mergify conflict #430

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #13740: corrected typo

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
Co-authored-by: Juanjo Garcia <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Jan 17, 2025
Signed-off-by: Juanjo Garcia <[email protected]>
Co-authored-by: Juanjo Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastddsgen hang when using two -I options pointing to the same folder [13740]
2 participants