-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13740] Add afunction that checks for repeated -I paths (issue #78) #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juanjo Garcia <[email protected]>
MiguelCompany
approved these changes
Jan 10, 2025
@Mergifyio backport 3.3.x 2.5.x 2.1.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
Signed-off-by: Juanjo Garcia <[email protected]> (cherry picked from commit 5f95b79) # Conflicts: # src/main/java/com/eprosima/fastdds/fastddsgen.java
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
Signed-off-by: Juanjo Garcia <[email protected]> (cherry picked from commit 5f95b79) # Conflicts: # src/main/java/com/eprosima/fastdds/fastddsgen.java
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
Signed-off-by: Juanjo Garcia <[email protected]> (cherry picked from commit 5f95b79) # Conflicts: # src/main/java/com/eprosima/fastdds/fastddsgen.java
This was referenced Jan 10, 2025
EugenioCollado
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Refs #13740: Solved mergify conflict #430 Signed-off-by: Juanjo Garcia <[email protected]> * Refs #13740: corrected typo Signed-off-by: Juanjo Garcia <[email protected]> --------- Signed-off-by: Juanjo Garcia <[email protected]> Co-authored-by: Juanjo Garcia <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Juanjo Garcia <[email protected]> Co-authored-by: Juanjo Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a function that checks if the paths included with the -I function have already been added, and skips them if so. This solves issue #78, and was suggested by the original author. I had to update a couple of terms to the new notation, so we should be careful with backports.
@Mergifyio backport 3.3.x 2.5.x 2.1.x
Fixes #78
Contributor Checklist
Reviewer Checklist