-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually fix a set of Topic QoS, and implement the max-tx-rate, max-rx-rate, and downsampling #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tempate
force-pushed
the
feature/manual_topics_conf
branch
from
October 9, 2023 08:15
110d282
to
760b66f
Compare
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Tempate
force-pushed
the
feature/manual_topics_conf
branch
from
October 11, 2023 06:41
69e25e8
to
c3c92da
Compare
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Tempate
force-pushed
the
feature/manual_topics_conf
branch
from
November 7, 2023 09:27
9622201
to
eb78b59
Compare
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
juanlofer-eprosima
had a problem deploying
to
codecov
November 8, 2023 07:23 — with
GitHub Actions
Error
Signed-off-by: Juan Lopez Fernandez <[email protected]>
juanlofer-eprosima
force-pushed
the
feature/manual_topics_conf
branch
from
November 8, 2023 07:30
e486b04
to
13d68e1
Compare
juanlofer-eprosima
temporarily deployed
to
codecov
November 8, 2023 07:30 — with
GitHub Actions
Inactive
juanlofer-eprosima
temporarily deployed
to
codecov
November 8, 2023 10:33 — with
GitHub Actions
Inactive
juanlofer-eprosima
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jepemi
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version, topics' QoS are configurable. The set of predefined topics' QoS takes precedence over the discovered topics' QoS.
The following features have also been implemented:
These features can be configured generically, per participant, and per topic.
Merge after: