Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix a set of Topic QoS, and implement the max-tx-rate, max-rx-rate, and downsampling #403

Merged
merged 42 commits into from
Nov 8, 2023

Conversation

Tempate
Copy link
Contributor

@Tempate Tempate commented Oct 6, 2023

In this version, topics' QoS are configurable. The set of predefined topics' QoS takes precedence over the discovered topics' QoS.

The following features have also been implemented:

  • max-tx-rate (max transmission rate): the transmission frequency for sent samples.
  • max-rx-rate (max reception rate): the processing frequency for received samples.
  • downsampling: the proportion of samples to process for received samples.

These features can be configured generically, per participant, and per topic.

Merge after:

Signed-off-by: tempate <[email protected]>
@Tempate Tempate marked this pull request as ready for review October 13, 2023 06:17
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 6140c85 into main Nov 8, 2023
19 of 20 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/manual_topics_conf branch November 8, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants