Skip to content

chore: Remove peerdepencies #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

chore: Remove peerdepencies #631

merged 3 commits into from
Feb 21, 2025

Conversation

salisdemos
Copy link
Collaborator

after vuex is removed in the code and only used in tests, we don't need to require vue/compat nor vuex as peerdependencies.

  • no need to update tests or documentation

- after vuex is removed in the code and only used in tests, we don't need to require vue/compat nor vuex as peerdependencies.
@salisdemos salisdemos requested a review from eFrane February 21, 2025 10:57
@salisdemos salisdemos self-assigned this Feb 21, 2025
@salisdemos salisdemos added the enhancement New feature or request label Feb 21, 2025
Copy link
Owner

@eFrane eFrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very correct, thanks for the chore!

@eFrane eFrane merged commit febe7d5 into main Feb 21, 2025
1 check passed
@eFrane eFrane deleted the remove_peerdepencies branch February 21, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants