Remove std::move() in async_alloc_write. #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we do move() for rreq which 1. has no effect on write_with_data path as rreq is captured by value which is a const. 2. make rreq (intrusive_ptr) to NULL after move and causing panic in handle_error(rreq) later. Removing the move() to fix the bug, though with a cost of extra atomic_inc/dec Signed-off-by: Xiaoxi Chen <[email protected]>
xiaoxichen
commented
Mar 8, 2024
| @@ -121,7 +121,7 @@ void RaftReplDev::async_alloc_write(sisl::blob const& header, sisl::blob const& | |||
| // Write the data | |||
| data_service().async_write(rreq->value, rreq->local_blkid).thenValue([this, rreq](auto&& err) { | |||
| if (!err) { | |||
| auto raft_status = m_state_machine->propose_to_raft(std::move(rreq)); | |||
There was a problem hiding this comment.
the rreq is a const so actually the move is not happening, that is the reason the handle_error in L125 can pass
hkadayam
approved these changes
Mar 9, 2024
yamingk
reviewed
Mar 9, 2024
yamingk
reviewed
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we do move() for rreq which
Removing the move() to fix the bug, though with a cost of extra atomic_inc/dec