Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable restartability for homeobject #145

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

JacksonYao287
Copy link
Collaborator

@JacksonYao287 JacksonYao287 commented Feb 20, 2024

since we have restartability in homestore, enable the restartability in homeobject now

in the current implementation , when restarting, repl_dev will not be loaded when restarting meta service, it will be postponed to the the start of raft_repl_service. but when restarting, Pg is recovered when restarting metaservice , which will get the repl_dev from raft_repl_service, this causes an error.

@JacksonYao287 JacksonYao287 self-assigned this Feb 20, 2024
@JacksonYao287 JacksonYao287 linked an issue Feb 22, 2024 that may be closed by this pull request
@JacksonYao287 JacksonYao287 added this to the MileStone4.1 milestone Feb 22, 2024
@JacksonYao287 JacksonYao287 added the enhancement New feature or request label Feb 22, 2024
@JacksonYao287 JacksonYao287 changed the title enable restartability enable restartability for homeobject Feb 22, 2024
@JacksonYao287
Copy link
Collaborator Author

UT will succeed after eBay/HomeStore#333 is merged

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.47%. Comparing base (523cf8e) to head (2a3f4b2).

Files Patch % Lines
src/lib/homestore_backend/hs_pg_manager.cpp 77.77% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   71.16%   75.47%   +4.30%     
==========================================
  Files          30       30              
  Lines        1311     1313       +2     
  Branches      132      137       +5     
==========================================
+ Hits          933      991      +58     
+ Misses        301      244      -57     
- Partials       77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoxichen
Copy link
Collaborator

This PR is right in general , but I have concern regarding caching all the shard info in memory during recovery as the # of shard is technically unbound, unless GC will recycle empty shard.

@xiaoxichen
Copy link
Collaborator

based on the discussion today, we will merge this PR to unblock the test. In the meantime we will rework this to defer the recover of PG/Shard after HS recover.

@xiaoxichen xiaoxichen merged commit 1596451 into eBay:main Feb 28, 2024
24 checks passed
@JacksonYao287 JacksonYao287 deleted the enable-restartability branch August 6, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable recovery test after HS reboot-recoverable.
3 participants