Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added developer panel #497

Conversation

mishushakov
Copy link
Member

  • Click on team dropdown > Developer
  • Setting alternative API URL
  • Setting alternative Billing URL
  • Resetting the above to defaults (provided by env variable)

@mishushakov mishushakov requested a review from jakubno as a code owner December 6, 2024 20:39
Copy link

linear bot commented Dec 6, 2024

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 7360cfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mlejva
Copy link
Member

mlejva commented Dec 6, 2024

Looks like the auth for preview URLs stopped working because it redirects to the production URL

auth.mp4

@mishushakov
Copy link
Member Author

try with username/password for now, not related to this

@mlejva
Copy link
Member

mlejva commented Dec 6, 2024

Thanks, works now.

  1. Please fix the unnecessary scrolling and broken footer
  2. What's the reason to have the "Developer" button in the team dropdown and not as one of the tabs on the left? I want to better understand the thinking here
  3. Please change the developer icon to something else because this icon is associated with bugs
dash.mp4

@mishushakov
Copy link
Member Author

  1. on it
  2. it's a hidden setting
  3. on it

@mishushakov
Copy link
Member Author

mishushakov commented Dec 6, 2024

removed scrolling and made footer not-so-ugly
change icon to more "friendly" one

@mlejva
Copy link
Member

mlejva commented Dec 6, 2024

  1. it's a hidden setting

I get the hidden element of it it just doesn't sit well with me that it's in the team selection. Do we need to "hide" it?

@mlejva
Copy link
Member

mlejva commented Dec 6, 2024

Great, thanks! Let's go a little bit further in the UX and:

  1. Add description of what each field is for like this:
    Screenshot 2024-12-06 at 1 46 10 PM

  2. My understanding is that if a user changes the API URL, it implies they're running on a separate cluster and they should set the E2B_DOMAIN env var when using our SDK. I want us to show a code snippet showing that the user should set the env var. For example if API URL is api.domain.com people should set E2B_DOMAIN=domain.com before using our SDK. Think of it as a simple "getting started" code snippet. Does that make sense?

  3. I find it a bit confusing that no tab on the left is selected because the developer settings is in the dropdown menu. It's just a bit inconsistent. I think we don't need to hide it.

Screenshot 2024-12-06 at 1 51 38 PM

@mishushakov
Copy link
Member Author

updated
Screenshot 2024-12-06 at 23 31 45

@mlejva
Copy link
Member

mlejva commented Dec 6, 2024

I pushed some minor updates. I spoke with @jakubno that we can hide the billing URL for now and it should work for users as well.

@mishushakov mishushakov merged commit 4a6e884 into main Dec 6, 2024
2 checks passed
@mishushakov mishushakov deleted the allow-setting-alternative-cluster-address-in-dashboard-e2b-1258 branch December 6, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants