Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment heading change to enable templating #5313

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

rica-carv
Copy link
Contributor

@rica-carv rica-carv commented Aug 4, 2024

Motivation and Context

The comments area heading is hardcoded inside the class, so no way to template it or change, for instance, from a span to a div or some other html tag.
With this change it can be fully templated via the comments_template, using somethig like $COMMENT_TEMPLATE['start'] = "{LAN=LAN_COMMENTS}: <span id='e-comment-total'>{TOTAL_COMMENTS}</span>";

Description

Retained the old code, so if there's no template, it will render as usual.

How Has This Been Tested?

Tested in my theme and with v 2.3.3

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant