db_verify::getIndex(): Support index_col_name optional parts
#5055
Conversation
|
Thank you for this @Deltik ! |
|
Yep, I'll add a test now, @CaMer0n |
In the MariaDB `CREATE TABLE` [`index_definition`](https://mariadb.com/kb/en/create-table/#index-definitions), the `index_col_name` could have an optional length and a sort order: ``` index_definition: {INDEX|KEY} [index_name] [index_type] (index_col_name,...) [index_option] ... {{{|}}} {FULLTEXT|SPATIAL} [INDEX|KEY] [index_name] (index_col_name,...) [index_option] ... {{{|}}} [CONSTRAINT [symbol]] PRIMARY KEY [index_type] (index_col_name,...) [index_option] ... {{{|}}} [CONSTRAINT [symbol]] UNIQUE [INDEX|KEY] [index_name] [index_type] (index_col_name,...) [index_option] ... {{{|}}} [CONSTRAINT [symbol]] FOREIGN KEY [index_name] (index_col_name,...) reference_definition index_col_name: col_name [(length)] [ASC | DESC] index_type: USING {BTREE | HASH | RTREE} index_option: [ KEY_BLOCK_SIZE [=] value {{{|}}} index_type {{{|}}} WITH PARSER parser_name {{{|}}} COMMENT 'string' {{{|}}} CLUSTERING={YES| NO} ] [ IGNORED | NOT IGNORED ] reference_definition: REFERENCES tbl_name (index_col_name,...) [MATCH FULL | MATCH PARTIAL | MATCH SIMPLE] [ON DELETE reference_option] [ON UPDATE reference_option] reference_option: RESTRICT | CASCADE | SET NULL | NO ACTION ``` `db_verify::getIndex()` didn't handle this possibility, leading to a database validity check failure despite the index actually existing. Fixes: e107inc#5054
|
Test added, and actually fixed another matching bug when the optional length was omitted: https://github.com/e107inc/e107/compare/ceddd798f04da034735ea340fbf8f733733bb378..b623868756e99b65c0c9f03d09b0f45dad6ef4a4#diff-940e04ed023a2601964002f97da3727414c057256735fc831fbd1fa1aab7703bL1068 |
|
Code Climate has analyzed commit b623868 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 34.5% (0.0% change). View more on Code Climate. |
|
Thank you!! 👍 |
Motivation and Context
Fixes: #5054
Description
Update the regex in
db_verify::getIndex()to support the optional parts ofindex_col_nameHow Has This Been Tested?
Automated test method:
db_verifyTest::testGetIndexOptionalLengthAndSortOrder()Types of Changes
Checklist