Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split settings.BASE_DIR into MODULE and DATADIR #2374

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Split settings.BASE_DIR into MODULE and DATADIR #2374

merged 6 commits into from
Feb 3, 2025

Conversation

niklasmohrin
Copy link
Member

This is in preparation for #2328

The idea is that we don't want to place any files at runtime into MODULE, as that might be venv/lib/python3.10/site-packages/evap/, or a path into the Nix store or something similar.

Best reviewed by commit.

@niklasmohrin niklasmohrin force-pushed the settings-basedir branch 4 times, most recently from ea891e1 to f32726c Compare January 20, 2025 20:13
@niklasmohrin
Copy link
Member Author

@janno42 This could require small changes to the settings on production

Kakadus
Kakadus reviewed Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@Kakadus Kakadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general

evap/evaluation/tests/test_misc.py Outdated Show resolved Hide resolved
evap/development/fixtures/upload/grades/1577/test_results_03.txt Outdated Show resolved Hide resolved
richardebeling
richardebeling approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendship ended with os.path.join. This is so nice, we should have done this years ago.

.gitignore Outdated Show resolved Hide resolved
evap/development/management/commands/reload_testdata.py Show resolved Hide resolved
@niklasmohrin niklasmohrin merged commit d5bf155 into e-valuation:main Feb 3, 2025
12 of 13 checks passed
@niklasmohrin niklasmohrin deleted the settings-basedir branch February 3, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakadus Kakadus Kakadus approved these changes

@richardebeling richardebeling richardebeling approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasmohrin @richardebeling @Kakadus