Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint tseslint config #2285

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add eslint tseslint config #2285

wants to merge 2 commits into from

Conversation

Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented Sep 23, 2024 •
edited
Loading

Enables just recommended configs from eslint, strict typecheck and stylistic configs from tseslint.

This will not run in ci because it would just fail. Intended for local checks and Codacy: Codacy should pick this up and only check the diff

@Kakadus Kakadus marked this pull request as draft September 30, 2024 15:27
richardebeling
richardebeling requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed: If we provide a config, it should run and pass in CI

@Kakadus Kakadus changed the title Add eslit tseslint config Add eslint tseslint config Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardebeling richardebeling richardebeling requested changes

@niklasmohrin niklasmohrin Awaiting requested review from niklasmohrin

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kakadus @richardebeling