Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds shortcut button to add exam evaluation #2050

Merged
merged 46 commits into from
Dec 16, 2024
Merged

Adds shortcut button to add exam evaluation #2050

merged 46 commits into from
Dec 16, 2024

Conversation

FSadrieh
Copy link
Collaborator

@FSadrieh FSadrieh commented Oct 23, 2023 •
edited
Loading

@richardebeling richardebeling marked this pull request as draft October 23, 2023 18:30
@FSadrieh FSadrieh marked this pull request as ready for review November 20, 2023 18:08
richardebeling
richardebeling requested changes Nov 21, 2023
View reviewed changes
evap/staff/templates/staff_semester_view.html Outdated Show resolved Hide resolved
evap/staff/urls.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
@janno42 janno42 linked an issue Nov 27, 2023 that may be closed by this pull request
Shortcut button for creating exam evaluation #2008
Closed
janno42
janno42 requested changes Nov 27, 2023
View reviewed changes
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin reviewed Jan 21, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a quick skim 👍 I will take a closer look once the modals are done and in use here

evap/staff/views.py Outdated Show resolved Hide resolved
@richardebeling
Copy link
Member

@FSadrieh Modals are merged so you should be un-blocked here now

@Kakadus Kakadus self-requested a review April 15, 2024 18:22
Kakadus
Kakadus requested changes Apr 15, 2024
View reviewed changes
evap/settings.py Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
janno42
janno42 reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested yet, will submit another review

evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/views.py Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
@Kakadus Kakadus self-requested a review April 29, 2024 18:01
janno42
janno42 requested changes Apr 29, 2024
View reviewed changes
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
deployment/localsettings.template.py Outdated Show resolved Hide resolved
Kakadus
Kakadus requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@Kakadus Kakadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 👍

@Kakadus Kakadus force-pushed the shortcut-to-exam branch from 7ec23b1 to f08ef58 Compare May 6, 2024 17:25
richardebeling
richardebeling reviewed May 6, 2024
View reviewed changes
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
richardebeling
richardebeling requested changes Jun 9, 2024
View reviewed changes
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments before I take a closer look at the view code; confirmation modal usage is mostly correct, only some subtleties 👍

evap/staff/templates/staff_semester_view.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
@niklasmohrin niklasmohrin mentioned this pull request Jul 29, 2024
Merged
@Kakadus Kakadus self-requested a review August 26, 2024 17:21
richardebeling
richardebeling requested changes Aug 26, 2024
View reviewed changes
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
Frederic Sadrieh and others added 24 commits December 3, 2024 10:09
@FSadrieh
Include strptime into bad request
1674ce4
@FSadrieh
Fix
fbac0d0
@FSadrieh
[WIP]: Start with date checker
4d85af3
@FSadrieh
Better datechecker
8f09132
@FSadrieh
[WIP]: Better white space detection
ce74982
@FSadrieh
Working again
618f23c
@FSadrieh
Fixed format and lint
2818a36
@FSadrieh
Some minor refactors
a98f963
@FSadrieh
Fix tests
d469b1c
@FSadrieh
Nice things
77072b9
@FSadrieh
[WIP]: Better no database modification
92aa552
@FSadrieh
[Feat]: Better assert_no_database_modifications and exam date checking
82fe385
@FSadrieh
Exchanged legal with possible
a8d4421
@FSadrieh
Fixed has_exam
abbe926
@FSadrieh
Fixed second has_exam
30d5311
@FSadrieh
Remove unused import
bf6a95b
@FSadrieh
Check missing exam date and wrong format exam date seperatly
00e2daa
@FSadrieh
Renamed variable
66873c1
@FSadrieh
More consistent naming
995774c
@FSadrieh
Some minor improvements
1001374
@FSadrieh
Minor formating
de25f67
@FSadrieh
Added test for wrong evaluation date
2e5fdcb
@FSadrieh
Add min date
884b501
@FSadrieh @janno42
Apply message suggestions from Janno
c6435db 
Co-authored-by: Johannes Wolf <[email protected]>
niklasmohrin
niklasmohrin reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, only one concern left before I want to approve

evap/evaluation/models.py Show resolved Hide resolved
@niklasmohrin niklasmohrin merged commit 80bd1c8 into e-valuation:main Dec 16, 2024
13 checks passed
@richardebeling
Copy link
Member

🎉

jooooosef pushed a commit to jooooosef/EvaP that referenced this pull request Jan 13, 2025
@FSadrieh @janno42 @jooooosef
Add shortcut button to add exam evaluation (e-valuation#2050)
25b1feb 
Co-authored-by: FSadrieh <[email protected]>
Co-authored-by: Johannes Wolf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janno42 janno42 janno42 approved these changes

@Kakadus Kakadus Kakadus approved these changes

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcut button for creating exam evaluation
5 participants
@FSadrieh @richardebeling @janno42 @niklasmohrin @Kakadus