Reverted #124 and Added Logging #146
Conversation
|
@shankari @JGreenlee please review |
There was a problem hiding this comment.
Since this change is going to be reverted anyway, I don't care as much about its code quality, just as long as it works.
@TeachMeTW can you please indicate how you tested this? I am deploying it to staging regardless.
| def render_content( | ||
| tab, | ||
| store_uuids, | ||
| store_excluded_uuids, | ||
| store_trips, | ||
| store_demographics, | ||
| store_trajectories, | ||
| start_date, | ||
| end_date, | ||
| timezone, | ||
| key_list, | ||
| loaded_uuids_store, | ||
| all_data_loaded | ||
| ): |
There was a problem hiding this comment.
There are some extraneous whitespace changes here, but I am not going to complain about them since we will revert this commit.
| ) | ||
|
|
||
| elif tab == 'tab-trips-datatable': | ||
| # **Handle Trips Tab with Batch Loading (New Implementation)** |
There was a problem hiding this comment.
Presumably this comment is no longer accurate
| return None, loaded_uuids_store, True | ||
|
|
||
| elif tab == 'tab-trajectories-datatable': | ||
| # **Handle Trajectories Tab with Batch Loading (New Implementation)** |
It was a simple test, just loaded up a dataset and watched the UUIDs tab load like previously. I tested with open access and load times came to be about 280 seconds. |
|
As I indicated on Teams, after deploying on to staging, the Trips tab is broken. It doesn't display anything. 
|
|
I hope this is a learning experience on the importance of testing everything while making changes. After we have verified this on staging, we need to revisit the proposed timeline in #145 |
Revert Batching Changes and Implement Baseline Logging
Description
Changes Implemented
Reverted to Baseline
Implemented Baseline Logging
add_user_statsandrender_contentTesting Performed
Related Issues
Notes