🐛 fix UI error when enter_fmt_time or exit_fmt_time missing #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed trips always have start_fmt_time and end_fmt_time, but confirmed places are not guaranteed to have enter_fmt_time and exit_fmt_time. Commonly, the last place has not been exited and does not have an exit_fmt_time Thus, this could be undefined and cause an error when we try to take .substring. It is ok to This only affected configs with place inputs (e.g. stage-timeuse) because other configs do not show places in the UI
…into fix-substring-missing-fmt-time
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1195 +/- ##
=======================================
Coverage 29.78% 29.78%
=======================================
Files 123 123
Lines 4955 4955
Branches 1095 1139 +44
=======================================
Hits 1476 1476
+ Misses 3479 3477 -2
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes e-mission/e-mission-docs#1108 (comment)
Confirmed trips always have start_fmt_time and end_fmt_time, but confirmed places are not guaranteed to have enter_fmt_time and exit_fmt_time. Commonly, the last place has not been exited and does not have an exit_fmt_time
Thus, this could be undefined and cause an error when we try to take .substring
This only affected configs with place inputs (e.g. stage-timeuse) because other configs do not show places in the UI