Add initial GPU support to the loop context code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---- Signed-off-by: Lydia Duncan <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Fixes `unmanaged` not being deleted in test. Causes the test to fail when ran with `--memLeaks`. Test added in chapel-lang#22091
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
This PR removes some redundant dependencies from the Makefile for `chpldoc`. Because CMake is building `chpldoc`, the dependency on `chpl` is maintained there, so make should not try to build `chpl` as a dependency, but rather issue the command to CMake which will then build the proper dependency targets for `chpldoc`. While I was here I also removed the `DYNO_CHPLDOC_OBJS` target. Also removed the `chpldoc` `COPYRIGHT` file and replaced with the same code we use to generate the `COPYRIGHT` file for `chpl`. This prevents a hidden dependency on building `chpl` before `chpldoc` in order to get the `COPYRIGHT` file generated, and instead moves the dependency on generating the `COPYRIGHT` file for `chpldoc` to CMake. TESTING: - [x] paratest `[Summary: #Successes = 14774 | #Failures = 0 | #Futures = 907]` - [x] gen_release makes tar that can then build chpl and chpldoc reviewed by @mppf - thanks!
Signed-off-by: Ben Harshbarger <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
…22126) [reviewed by @arezaii] - Removes wording about replacing the deprecated attribute with a different syntax. That has now occurred - Move "When we produce a compiler warning" sentence to the following paragraph, which references it. This seemed better than making them all one paragraph, and will clarify what is being talked about in that paragraph Double checked the built docs
[reviewed by @jabraham17] After some discussion with Damian about other default symbols, we have decided to undo the deprecation of including `carg` by default. Since the previous PR involved a documentation improvement, this was not a pure revert. Remove the test that was locking in the carg deprecation from AutoMath Passed a full paratest with futures
…g#22131) adds an option to the `lines()` iterator on `fileReader` to remove the trailing newline. ```chapel iter fileReader.lines(stripNewline = false) ``` ## Summary of changes - implement `stripNewline` - augment an existing `lines()` test to test new option ## new tests - add a new test just for `fileReader.lines()` to test boundary conditions ## testing - paratest --- [Reviewed by @jeremiah-corrado] closes chapel-lang#19547 closes Cray/chapel-private#4734
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
libfabric version 1.17.1 fixes a segmentation fault with the verbs provider in test/performance/comm/barrier/empty-chpl-barrier.chpl that occurs in version 1.13.2.
Signed-off-by: Anna Rift <[email protected]>
Follow-up to PR chapel-lang#21944. This PR fixes a problem in warning option handling for the clang invocation in the new extern block handling. The warning options were not being handled correctly. Clang configures warnings through diagnostics options & these were being constructed with default settings. With this PR, the diagnostic options are computed from the clang command line. This PR switches two other clang integration points to use the pattern that handles the warning options correctly. This PR is meant to resolve failures with the gsl_demo.chpl test. - [x] full local testing (but with [Error matching program output for c2chapel/c2chapel-tester] which fails on main currently, this PR does not change the situation) Reviewed by @riftEmber - thanks!
Adds a test for passing a pointer to a const array to a (possibly extern) function, as well as passing a non-const pointer to a non-const copy of the array to the same function. This test locks in the behavior expected by chapel-lang#18790, which was implemented in chapel-lang#21913. [trivial, not reviewed] Testing: - [x] new test `test/types/cptr/const/const_array.chpl` passes
Fixes `test/c2chapel/c2chapel-tester.good` for addition of const pointer test in chapel-lang#21913. The const pointer c2chapel test appears to be working properly, but I had neglected to update this `.good` to expect output from it. [reviewed by @mppf , thanks!] Testing: - [x] c2chapel tests locally - [x] paratest (which appears not to cover this test?)
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
This is a second attempt at fixing an incorrect strict aliasing warning when casting from a `c_ptr(c_string)` to a `c_ptr(c_ptr(c_char))`, which is causing nightly test failures. This is a follow up to the first attempt in chapel-lang#22116 which fixed part of the issue. Although comparing pointee types is fixed, the strict aliasing check was incorrectly warning on the cast from the contained pointee types `c_string` to `c_ptr(c_char)`. This is not tripped for a direct cast from a `c_string` to `c_ptr(c_char)` as that is separately implemented, and not handled via the cptr-to-cptr that has a strict aliasing check. This PR causes the check to treat a `c_string` as a pointer to `c_char` for the purpose of aliasing. It works for casting either to or from a c_string pointee, and adds testing for both. [reviewed by @mppf , thanks!] Testing: - [x] paratest - [x] locally testing `interop/fortran/FortranCallChapel/chapelProcs` and `interop/fortran/genFortranInterface/chapelProcs` (can't run the fortran, but aliasing warning is observed before this PR anyways)
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Daniel Fedorin <[email protected]>
Signed-off-by: Daniel Fedorin <[email protected]>
Signed-off-by: Daniel Fedorin <[email protected]>
Signed-off-by: Daniel Fedorin <[email protected]>
Signed-off-by: Daniel Fedorin <[email protected]>
Signed-off-by: Daniel Fedorin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.