Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap php package #30

Merged
merged 6 commits into from
Oct 15, 2020
Merged

Bootstrap php package #30

merged 6 commits into from
Oct 15, 2020

Conversation

f94a5d1685cb014
Copy link

@f94a5d1685cb014 f94a5d1685cb014 commented Oct 14, 2020

Description

Bootstrap package by adding unit tests support and enabling class autoloading.
See also #10

Type of change

  • New feature (non-breaking change which adds functionality)

@github-actions github-actions bot added the php PHP related changes label Oct 14, 2020
},
"autoload": {
"psr-4": {
"Dzcodeio\\Kuliya\\": "src/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand well php and composer, but if it's possible, can u make all files/dirs lowercased ( either python-cased or snake_cased ) to avoid across OSs file-system issues

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most popular php projects/frameworks use PascalCase for file/dir names so i dont think that would cause any issues but i can use snake_case starting from the next PR. As for namespaces, Class/Method names and class file names i chose to respect PHP standard recommendations, specificaly PSR-4 for class autoloading and PSR-12 for code style which suggests adopting PascalCase for namespaces/classes and class file names and camelCase for methods.

Copy link
Member

@ZibanPirate ZibanPirate Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case then, it's better to keep it consistent across the php folder, so let it be PascalCased 👌🏽.

Just note that later on, changing letter cases will cause problems on windows.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh i see! thanks for the hint, i'll investigate on it then and use the best strategy possible.

},
"autoload-dev": {
"psr-4": {
"Dzcodeio\\Kulyia\\Test\\": "tests/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same casing request

@ZibanPirate ZibanPirate merged commit 11bb39d into dzcode-io:main Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants