[Partial][example][ui] Udash docker log and exec #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at15
added
pkg/ui
lib/dockerclient
example/udash
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
========================================
+ Coverage 45.2% 48.4% +3.2%
========================================
Files 6 7 +1
Lines 250 283 +33
========================================
+ Hits 113 137 +24
- Misses 110 117 +7
- Partials 27 29 +2
Continue to review full report at Codecov.
|
- https://github.com/philipwalton/solved-by-flexbox is really nice, just simple example for me to figure out which property is having effect ...
- use `justify-content` and `align-item` (same thing on two axises)
- [ ] TODO: the sidebar is not fixed ...
- sidebar can have fixed content
- although the transport is shared, it has pooling disabled - also when calling `Transport` on client, default transports are not returned
- copied from #43 udash.html but height is not expanding
- don't know why it was not needed in playground ... - https://stackoverflow.com/questions/20681420/css-height-not-working-if-body-has-min-height - https://www.kirupa.com/html5/make_body_take_up_full_browser_height.htm
- use el-row and el-span with width 24 (totoal 24 cols) - https://element.eleme.io/#/en-US/component/menu
- `/api/local/docker/images` now returns image info
- when log has the time option, it is using the timestamp from docker daemon, which is always UTC, this makes the log on the client side a bit hard to reason about ...
- first need to create a exec - then attach to it and use the raw underlying connection ...
- but it seems the pty is just echo, something wrong in the order of reader and writer etc.
- when browser sending command, it didn't contains a `/n`, so bash never interact with it, figured it out when looking at original example from gorilla/websocket
- what worked for single command no longer works for xterm
at15
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
TODO
Ref