Merge pull request #42 from dyweb/todo/exec

Go run shell commands properly

.ayi.example.yml

@@ -1,7 +1,6 @@
 debug: true
 test:
-    # FIXME: why sh is needed.... why can't just run the script
-    - sh ./scripts/test.sh
+    - sh -c "go test -v -cover $(glide novendor)"
 user: example-user
 project:
     name: example

util/command.go

@@ -10,17 +10,12 @@ import (
 
 // Command return a Command struct from a full commad
 func Command(cmd string) (*exec.Cmd, error) {
+	// NOTE: do not use strings.Fields or Split !
 	segments, err := shellquote.Split(cmd)
 	if err != nil {
 		return nil, errors.Wrap(err, "Cannot parse command")
 	}
 	name := segments[0]
-	// FIXME: this is not working ...
-	// if (name == "sh") && (segments[1] == "-c") {
-	// 	// TODO: this does not support use like go test $(glide novendor)
-	// 	fmt.Println(strings.Join(segments[2:], " "))
-	// 	return exec.Command("sh", "-c", strings.Join(segments[2:], " "))
-	// }
 	return exec.Command(name, segments[1:]...), nil
 }
 

util/command_test.go

@@ -10,10 +10,7 @@ func TestCommand(t *testing.T) {
 	assert := assert.New(t)
 	cmd, _ := Command("ls")
 	assert.Equal(1, len(cmd.Args))
-	// FIXME: $(glide novendor) will not be interpreted
-	// TODO: try sh -c "go test -v -cover $(glide novendor)"
-	cmd, _ = Command("go test -v -cover $(glide novendor)")
-	assert.Equal("test", cmd.Args[1])
+	// NOTE: you must use sh -c since subshell is included
 	cmd, _ = Command("sh -c \"go test -v -cover $(glide novendor)\"")
 	assert.Equal("go test -v -cover $(glide novendor)", cmd.Args[2])
 }