-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Eurostat
source and Prefect tasks
#1041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my feedback. It might be easier to create one issue to address the changes for which I haven't added suggestions (except unit tests as these should be fixed before merging).
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks like the unit tests still don't mock the API calls.
- It seems docs are also not added. See https://viadot.docs.dyvenia.com/developer_guide/creating_a_source/#adding-docs and https://viadot.docs.dyvenia.com/developer_guide/creating_a_prefect_flow/#adding-docs
- There's one open conversation left from before
Co-authored-by: Michał Zawadzki <[email protected]>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
6616985 | Triggered | Generic Password | c3589a1 | tests/unit/test_business_core.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@Rafalz13 the other "unit" tests are also not unit tests; they try to connect to the actual API. So the mocking in general is incorrect and needs fixing (once you fix it you might as well re-add the |
@zawadzki Tests don't connect to the source after changes. Test coverage is 80%. |
Summary
Adding Eurostat connector
Importance
To use Eurostat in Prefect 2.0
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md