Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bsc] initial pebble, init-from-gcs improvements #276

Merged
merged 5 commits into from
Dec 20, 2023
Merged

[bsc] initial pebble, init-from-gcs improvements #276

merged 5 commits into from
Dec 20, 2023

Conversation

voron
Copy link
Contributor

@voron voron commented Dec 20, 2023

  • Initial support of DB engine and state scheme, see BNB forum for FAQ. v1.3.x is required for pebble DB engine and path scheme. Pebble DB is still unstable
  • add baseUrlOverride to allow to bypass source auto-select and use specified value
  • exclude *.sst from ancient copy list, it's used for state with pebble db

@voron voron force-pushed the bsc-initial-pebble branch from 016a104 to c64b034 Compare December 20, 2023 14:55
@voron voron requested a review from VladStarr December 20, 2023 14:59
VladStarr
VladStarr requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@VladStarr VladStarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor points to fix for interoperability with 1.2.x BSC.

dysnix/bsc/values.yaml Outdated Show resolved Hide resolved
dysnix/bsc/values.yaml Outdated Show resolved Hide resolved
dysnix/bsc/templates/configs/_config.txt Show resolved Hide resolved
@voron voron force-pushed the bsc-initial-pebble branch from 49ed19b to f24a67a Compare December 20, 2023 15:32
VladStarr
VladStarr approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@VladStarr VladStarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voron voron merged commit e05b6a5 into main Dec 20, 2023
2 checks passed
@voron voron deleted the bsc-initial-pebble branch December 20, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladStarr VladStarr VladStarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voron @VladStarr