Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move prefix warning to validate_model #98

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

samsonjoyce
Copy link
Contributor

This is to prevent the warning from printing every time LIMinal is initialized. Instead, the test is only ran and warning only printed when all the models are validated, during compare, which is ran during autogenerate.

@samsonjoyce samsonjoyce added the type:task A general task label Jan 29, 2025
@samsonjoyce samsonjoyce linked an issue Jan 29, 2025 that may be closed by this pull request
@ndamania00 ndamania00 added semver:patch A backwards compatible bug fix (patch version bump) type:bug Something isn't working labels Feb 1, 2025
@ndamania00 ndamania00 merged commit 25bf06f into dynotx:main Feb 1, 2025
2 checks passed
@ndamania00 ndamania00 added type:bug Something isn't working and removed type:bug Something isn't working type:task A general task labels Feb 5, 2025
@samsonjoyce samsonjoyce deleted the prefix_warning branch February 7, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A backwards compatible bug fix (patch version bump) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move warning for reused prefix
2 participants