Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require SilverStripe Framework (instead of CMS+Framework) #16

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Require SilverStripe Framework (instead of CMS+Framework) #16

merged 1 commit into from
Jul 26, 2023

Conversation

nathanbrauer
Copy link
Contributor

@nathanbrauer nathanbrauer commented Jul 23, 2023

silverstripe-shorturls works perfectly without the CMS.

This commit allows framework-only users to use the module without the CMS.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d9e18ca) 67.01% compared to head (2b5d421) 67.01%.

Additional details and impacted files
@@            Coverage Diff            @@
##                  3      #16   +/-   ##
=========================================
  Coverage     67.01%   67.01%           
  Complexity       22       22           
=========================================
  Files             2        2           
  Lines            97       97           
=========================================
  Hits             65       65           
  Misses           32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsirish jsirish merged commit 64d143f into dynamic:3 Jul 26, 2023
10 checks passed
@jsirish
Copy link
Member

jsirish commented Jul 26, 2023

thanks @nathanbrauer ! Merged and tagged a new minor release.

@nathanbrauer nathanbrauer deleted the require-framework-only branch September 29, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants