Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR Bootstrap Templates #215

Open
wants to merge 1 commit into
base: 5
Choose a base branch
from

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Nov 22, 2022

works “out of the box” in bootstrap. JS requirements can be modified once the controller requirement issue has been determined

works “out of the box” in bootstrap. JS requirements can be modified once the controller requirement issue has been determined
@jsirish jsirish requested a review from muskie9 November 22, 2022 03:02
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 51.53% // Head: 51.53% // No change to project coverage 👍

Coverage data is based on head (7e85a11) compared to base (bc59221).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##                  5     #215   +/-   ##
=========================================
  Coverage     51.53%   51.53%           
  Complexity       82       82           
=========================================
  Files             5        5           
  Lines           260      260           
=========================================
  Hits            134      134           
  Misses          126      126           
Flag Coverage Δ
unittests 51.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

<% end_if %>
</li>
<% end_loop %>
</ul>
</div>
<% end_if %>
</div>
</div>
<% require javascript('//code.jquery.com/jquery-3.6.1.min.js') %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our convo, if we can localize this and not call it from the CDN it could then be blocked by developers if they bring their own version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now just copying it to a thridparty directory is fine, we can look at FE workflows in a later commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants