-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR Bootstrap Templates #215
base: 5
Are you sure you want to change the base?
Conversation
works “out of the box” in bootstrap. JS requirements can be modified once the controller requirement issue has been determined
Codecov ReportBase: 51.53% // Head: 51.53% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## 5 #215 +/- ##
=========================================
Coverage 51.53% 51.53%
Complexity 82 82
=========================================
Files 5 5
Lines 260 260
=========================================
Hits 134 134
Misses 126 126
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
<% end_if %> | ||
</li> | ||
<% end_loop %> | ||
</ul> | ||
</div> | ||
<% end_if %> | ||
</div> | ||
</div> | ||
<% require javascript('//code.jquery.com/jquery-3.6.1.min.js') %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our convo, if we can localize this and not call it from the CDN it could then be blocked by developers if they bring their own version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now just copying it to a thridparty directory is fine, we can look at FE workflows in a later commit.
works “out of the box” in bootstrap. JS requirements can be modified once the controller requirement issue has been determined