Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sanity command for checking dependencies #22

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jessecollier
Copy link
Collaborator

No description provided.

Comment on lines +12 to +20
//console.log(JSON.stringify(resolveModuleTree(rawTree), null, 2));
// const tree = annotateTree(rawTree);
// const filteredTree = Object.fromEntries(
// Object.entries(tree).filter(([, value]) => value?.meta?.isDynamic),
// );
// recurseVersionCheck(filteredTree);
// reporter();
//console.log(reporter(audit));
console.log(reporter(audit));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

const nodeModulesPackages = fs.readdirSync(nodeModulesPath);
// Filter out hidden directories (eg. .bin)
// Get fully scoped package names (eg. @dynamic-labs/sdk-api)
const nodules = nodeModulesPackages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodules – typo? did you mean modules?

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

83.1% Coverage on New Code (required ≥ 90%)
3 New Minor Issues (required ≤ 0)
13 New Major Issues (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

83.5% Coverage on New Code (required ≥ 90%)
13 New Major Issues (required ≤ 0)
3 New Minor Issues (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants