Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(validation): fix nil deref , and use validation result #1325

Merged
merged 4 commits into from
Jan 13, 2025
Merged

fix(validation): fix nil deref , and use validation result #1325

merged 4 commits into from
Jan 13, 2025

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Jan 9, 2025 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Closes #1240
Closes #1311

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner January 9, 2025 18:49
@danwt danwt changed the title nil fix fix(validation): fix nil deref , and use validation result Jan 9, 2025
@mtsitrin mtsitrin merged commit ace06fc into main Jan 13, 2025
4 checks passed
@mtsitrin mtsitrin deleted the danwt/1240-nil-fix2 branch January 13, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use p2p ValidationResult (Ignore) instead of just Accept/Reject Validator nil deref, missing proposer key
2 participants
@danwt @mtsitrin