feat(manager): allow starting node when sequencer is sentinel #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
reviewed
Dec 11, 2024
block/manager.go
Outdated
| @@ -232,7 +232,9 @@ func (m *Manager) Start(ctx context.Context) error { | |||
| if m.State.GetProposer() == nil { | |||
| m.logger.Info("No proposer on the rollapp, fallback to the hub proposer, if available") | |||
| err := m.UpdateProposerFromSL() | |||
| if err != nil { | |||
| if errors.Is(err, settlement.ErrProposerIsSentinel) { | |||
| m.freezeNode(fmt.Errorf("unable to start without new proposer at height %d", m.State.NextHeight())) | |||
There was a problem hiding this comment.
why u need it here? if u allow starting as full node anyway?
There was a problem hiding this comment.
this was added to freeze node instead of panicing when sentinel. however, i replaced it by a waiting function, so in case no active proposer is found it will wait til there is an active proposer, without requirng to restart.
block/manager.go
Outdated
| @@ -246,7 +248,9 @@ func (m *Manager) Start(ctx context.Context) error { | |||
| // for this case, 2 nodes will get `true` for `AmIProposer` so the l2 proposer can produce blocks and the hub proposer can submit his last batch. | |||
| // The hub proposer, after sending the last state update, will panic and restart as full node. | |||
| amIProposerOnSL, err := m.AmIProposerOnSL() | |||
There was a problem hiding this comment.
u can add
if errors.Is(err, settlement.ErrProposerIsSentinel) {
return false, nil
into m.AmIProposerOnSL()
omritoptix
reviewed
Feb 3, 2025
| @@ -347,8 +347,8 @@ func (c *Client) GetProposerAtHeight(height int64) (*types.Sequencer, error) { | |||
| } | |||
| } | |||
|
|
|||
| if proposerAddr == SENTINEL_PROPOSER { | |||
| return nil, fmt.Errorf("proposer is sentinel") | |||
| if proposerAddr == "" || proposerAddr == SENTINEL_PROPOSER { | |||
There was a problem hiding this comment.
when does == "" happens?
omritoptix
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1273,#1274
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: