fix(hardfork): integration fixes #1205
Conversation
…tion (#1189) Co-authored-by: Sergi Rene <[email protected]>
…sition' into hardfork/integration
…sition' into hardfork/integration
| @@ -41,7 +41,7 @@ func (m *Manager) ProduceBlockLoop(ctx context.Context, bytesProducedC chan int) | |||
| return nil | |||
| case <-ticker.C: | |||
| // Only produce if I'm the current rollapp proposer. | |||
| if !m.AmIProposerOnRollapp() { | |||
| if m.RunMode != RunModeProposer { | |||
There was a problem hiding this comment.
why is this modified? is this runMode not always be the same after start? i mean if the produceblockloop is started it already means is the proposer... and the runmode is not updated after start i think.
There was a problem hiding this comment.
so no reason to check against local keys each time again
There was a problem hiding this comment.
@mtsitrin this is for when you rotate.
during rotation you start as the proposer, but you shouldn't produce blocks after you produced your last block yet you should still send your last batch.
the code you introduced will make the proposer continue producing blocks while he's submitting his last batch in parallel to the new proposer.
i.e the "propoesr on the rollapp" can change while your in proposer mode.
|
not relevant anymore. superseeded by #1212 |
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: