Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validation): set right validation height #1187

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Oct 30, 2024

PR Standards

In the validation loop, it may fail to validate because it tries to validate to heights for blocks that are not applied yet.
This PR fixes this by never validating heights that are not applied yet.

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1186

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Oct 30, 2024
@srene srene requested a review from a team as a code owner October 30, 2024 16:50
@omritoptix omritoptix merged commit 6062b3a into main Nov 4, 2024
7 checks passed
@omritoptix omritoptix deleted the srene/1186-validation-height-fix branch November 4, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

full-node may try to validate unsynced heights and fail
2 participants