Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASI feature #19

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Add WASI feature #19

merged 3 commits into from
Feb 21, 2025

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Feb 18, 2025

Opt in to feature(wasip2) when we're building for the wasip2 target. This feels a little redundant but the compiler demands it.

Not tested yet.

Opt in to feature(wasip2) when we're building for the `wasip2` target. This feels a little redundant but the compiler demands it.
@Timmmm
Copy link
Contributor Author

Timmmm commented Feb 19, 2025

See rust-lang/rust#130323 (unfortunately this is not documented as far as I can see).

Actually based on the PRs linked to that issue maybe it should be

#![cfg_attr(
    all(feature = "nightly", target_os = "wasi", target_env = "p2"),
    feature(wasip2)
)]

but I'll do that when I get a response.

@dylni
Copy link
Owner

dylni commented Feb 21, 2025

Thanks! I'll get this released soon.

I do not find gating on "nightly" necessary, but I appreciate you raising it. Anyone using this target with this crate will need to be on the nightly channel currently, so the feature will only be an extra step for them.

@dylni dylni merged commit d768c35 into dylni:master Feb 21, 2025
29 checks passed
@dylni dylni mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants