Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Lwt from public OCaml interface #16

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Oct 3, 2023

No description provided.

@zshipko zshipko marked this pull request as draft October 3, 2023 23:55
@wikiwong
Copy link
Contributor

wikiwong commented Oct 6, 2023

will this essentially make all operations synchronous?

@zshipko
Copy link
Contributor Author

zshipko commented Oct 6, 2023

This is still using Lwt but it's just on top of the Eio scheduler, which is using Effects under the hood so it looks like "direct style". This code still needs to be wrapped in a call to Eio_main.run to work. So in the short term it simplifies the types a little, but it also allows us to introduce parallelism at some point in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants