Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add function to convert from proto to custom module type #63

Merged
merged 5 commits into from
Nov 1, 2023
Merged

feat: add function to convert from proto to custom module type #63

merged 5 commits into from
Nov 1, 2023

Conversation

wikiwong
Copy link
Contributor

@wikiwong wikiwong commented Oct 19, 2023 •
edited
Loading

add function to convert from proto to custom module type

@wikiwong wikiwong changed the title Feat: generate checkfile from proto feat: generate checkfile from proto Oct 19, 2023
@wikiwong wikiwong changed the title feat: generate checkfile from proto feat: add function to convert from proto to custom module type Nov 1, 2023
@nilslice
Copy link
Member

nilslice commented Nov 1, 2023

LGTM! Nice, the module conversion will be useful other places as well for sure

@wikiwong wikiwong merged commit 597caa9 into main Nov 1, 2023
37 checks passed
@wikiwong wikiwong deleted the gen-checkfile-proto branch November 1, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wikiwong @nilslice