Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial draft #104

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Add initial draft #104

merged 1 commit into from
Apr 14, 2024

Conversation

fnwirth
Copy link

@fnwirth fnwirth commented Feb 26, 2024

👉 Checklist

Please make sure to check off the following before submitting:

  • I have reviewed my submission thoroughly.
  • I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
  • I have run the JUnit tests (if submission is related to coding).
  • I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Please concisely describe the changes you have made.

  • Added a first draft of an internaltionalization feature including the languages German and English.
  • Remark: Is it possible that that the pom.xml needs to be uodated to Java 17?

🔗 Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #<issue_number>'.
#99

  • This Pull Request fixes the issue : 'Closes #'
  • This Pull Request does not fix an issue.

Thanks for taking the time to fill out this Pull Request! ❤️ Thanks for contributing to this project 🦖

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @fnwirth, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with the repository /dinosaur-exploder main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
  • ✅ Verify that you have well fill out the different checkboxes in the PR template.
  • ⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.
  • 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

@jvondermarck
Copy link
Collaborator

Thank you so much for your contribution !! It looks really good, great work @fnwirth !

Remark: Is it possible that that the pom.xml needs to be uodated to Java 17?
You mean you would like it to be updated to Java 17 ? But yes it could ne possible.

Copy link
Collaborator

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !!

@jvondermarck jvondermarck merged commit 4faff3c into dylan-power:main Apr 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants