Downgrade batch cancel logs

[jayy04]

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• New Features

  • Added a new metric SingleCancelInBatchCancelFailed to track specific cancellation events related to batch cancellations.

• Improvements

  • Adjusted logging levels for failure messages during short-term order cancellations to provide more precise debugging information.
  • Enhanced telemetry tracking for failed batch cancellations with a new counter for monitoring.

[coderabbitai]

Walkthrough

The pull request introduces a new constant SingleCancelInBatchCancelFailed in the metrics constants file and updates the BatchCancelShortTermOrder method in the CLOB keeper to track failed batch cancellations. The changes enhance the system's monitoring capabilities by adding a specific metric for tracking cancellation failures and adjusting logging to provide more precise debugging information.

Changes

File	Change Summary
protocol/lib/metrics/constants.go	Added new constant SingleCancelInBatchCancelFailed = "single_cancel_in_batch_cancel_failed" in the CLOB metrics section
protocol/x/clob/keeper/orders.go	- Changed logging level for failure messages from log.InfoLog to log.DebugLog - Added telemetry counter for tracking failed batch cancellations using metrics.SingleCancelInBatchCancelFailed

Poem

🐰 A Rabbit's Metric Tale 🔍
In code's vast warren, a metric springs to light,
Tracking cancels with precision and might.
Debug logs whisper, counters softly chime,
Batch failures caught in metrics' paradigm.
A rabbit's watch, forever keen and bright! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 295c3c4 and 4dd57a9.

📒 Files selected for processing (2)

• protocol/lib/metrics/constants.go (1 hunks)
• protocol/x/clob/keeper/orders.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• protocol/lib/metrics/constants.go
• protocol/x/clob/keeper/orders.go

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: liveness-test
• GitHub Check: test-coverage-upload
• GitHub Check: unit-end-to-end-and-integration
• GitHub Check: test-race
• GitHub Check: test-sim-import-export
• GitHub Check: test-sim-after-import
• GitHub Check: test-sim-multi-seed-short
• GitHub Check: container-tests
• GitHub Check: Summary

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[teddyding]

Nit: is metric name BatchCancelFailed accurate if this is incremented when one of the cancels on the BatchCancel fails?

[teddyding]

Something like single_cancel_in_batch_cancel_failed?