Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vault orderbook flickering #1638

Closed
wants to merge 21 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
publish protocol image
chenyaoy committed May 29, 2024
commit e087c19d0a3cc3c33c0c21b2e15e50e681a92c20
1 change: 1 addition & 0 deletions .github/workflows/protocol-build-and-push.yml
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@ on: # yamllint disable-line rule:truthy
- main
- 'release/protocol/v[0-9]+.[0-9]+.x' # e.g. release/protocol/v0.1.x
- 'release/protocol/v[0-9]+.x' # e.g. release/protocol/v1.x
- 'chenyao/order-replacement-messages-for-vault'

jobs:
build-and-push-dev:
2 changes: 0 additions & 2 deletions protocol/x/vault/keeper/orders.go
Original file line number Diff line number Diff line change
@@ -27,7 +27,6 @@ func (k Keeper) RefreshAllVaultOrders(ctx sdk.Context) {
defer totalSharesIterator.Close()
for ; totalSharesIterator.Valid(); totalSharesIterator.Next() {
vaultId, err := types.GetVaultIdFromStateKey(totalSharesIterator.Key())
fmt.Printf("vaultId: %+v\n", vaultId)

if err != nil {
log.ErrorLogWithError(ctx, "Failed to get vault ID from state key", err)
@@ -36,7 +35,6 @@ func (k Keeper) RefreshAllVaultOrders(ctx sdk.Context) {
var totalShares types.NumShares
k.cdc.MustUnmarshal(totalSharesIterator.Value(), &totalShares)

fmt.Printf("totalShares: %+v\n", totalShares)
// Skip if TotalShares is non-positive.
if totalShares.NumShares.Sign() <= 0 {
continue