rename block_already_parsed metric since it's now expected

[dydxwill]

Changelist

rename block_already_parsed metric since it's now expected
see dydxprotocol/v4-infrastructure#81 for context

Test Plan

unit tested

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[coderabbitai]

Walkthrough

The update focuses on modifying the metric key used in both testing and operational contexts for the scenario when a block has already been processed. Specifically, the .failure suffix is removed from the metric key related to the block already being parsed. This adjustment ensures consistency in metric naming and potentially alters how these events are classified and monitored.

Changes

File(s)	Change Summary
.../ender/__tests__/lib/on-message.test.ts	Removed .failure suffix from the metric key in the expect assertion for already parsed blocks.
.../ender/src/caches/block-cache.ts	Updated shouldSkipBlock function to remove .failure suffix from the stats increment key.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between dd41d0a and c10b2e9.

Files selected for processing (2)

• indexer/services/ender/tests/lib/on-message.test.ts (1 hunks)
• indexer/services/ender/src/caches/block-cache.ts (1 hunks)

Additional comments: 2

indexer/services/ender/src/caches/block-cache.ts (1)

• 54-54: The change correctly updates the metric name by removing the .failure suffix, aligning with the PR's objective. Ensure to update any monitoring or alerting configurations that might rely on the old metric name.

indexer/services/ender/__tests__/lib/on-message.test.ts (1)

• 762-762: The change correctly updates the metric name in the unit test assertion by removing the .failure suffix, aligning with the PR's objective and the corresponding change in block-cache.ts. Ensure to review any other tests or monitoring configurations that might rely on the old metric name.