Fix list append bug

dydxprotocol · Sep 30, 2024 · 804b7d2 · 804b7d2
1 parent 1fb2b95
commit 804b7d2
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/protocol/streaming/full_node_streaming_manager.go b/protocol/streaming/full_node_streaming_manager.go
@@ -516,7 +516,7 @@ func getStreamUpdatesFromOffchainUpdates(
 	// Unmarshal each per-clob pair message to v1 updates.
 	streamUpdates = make([]clobtypes.StreamUpdate, len(clobPairIds))
 
-	for _, clobPairId := range clobPairIds {
+	for i, clobPairId := range clobPairIds {
 		v1updates, exists := clobPairIdToV1Updates[clobPairId]
 		if !exists {
 			panic(fmt.Sprintf(
@@ -525,7 +525,7 @@ func getStreamUpdatesFromOffchainUpdates(
 				clobPairIdToV1Updates,
 			))
 		}
-		streamUpdate := clobtypes.StreamUpdate{
+		streamUpdates[i] = clobtypes.StreamUpdate{
 			UpdateMessage: &clobtypes.StreamUpdate_OrderbookUpdate{
 				OrderbookUpdate: &clobtypes.StreamOrderbookUpdate{
 					Updates:  v1updates,
@@ -535,7 +535,6 @@ func getStreamUpdatesFromOffchainUpdates(
 			BlockHeight: blockHeight,
 			ExecMode:    uint32(execMode),
 		}
-		streamUpdates = append(streamUpdates, streamUpdate)
 	}
 
 	return streamUpdates, clobPairIds