[TRA-509] skip vault order calculation if market price is 0 (backport #…

…1952) (#1953)

Co-authored-by: Tian <[email protected]>

protocol/x/vault/keeper/orders.go

@@ -178,6 +178,12 @@ func (k Keeper) GetVaultClobOrders(
 			err,
 			fmt.Sprintf("VaultId: %v", vaultId),
 		)
+	} else if marketPrice.Price == 0 {
+		// Market price can be zero upon market initialization or due to invalid exchange config.
+		return orders, errorsmod.Wrap(
+			types.ErrZeroMarketPrice,
+			fmt.Sprintf("VaultId: %v", vaultId),
+		)
 	}
 
 	// Calculate leverage = open notional / equity.
@@ -215,6 +221,8 @@ func (k Keeper) GetVaultClobOrders(
 	orderSize.Quo(orderSize, lib.BigIntOneMillion())
 
 	// Round (towards-zero) order size to the nearest multiple of step size.
+	// Note: below division by StepBaseQuantums is safe as x/clob disallows
+	// a clob pair's StepBaseQuantums to be zero.
 	stepSize := lib.BigU(clobPair.StepBaseQuantums)
 	orderSize.Quo(orderSize, stepSize).Mul(orderSize, stepSize)
 
@@ -315,6 +323,8 @@ func (k Keeper) GetVaultClobOrders(
 		}
 
 		// Bound subticks between the minimum and maximum subticks.
+		// Note: below division by SubticksPerTick is safe as x/clob disallows
+		// a clob pair's SubticksPerTick to be zero.
 		subticksPerTick := lib.BigU(clobPair.SubticksPerTick)
 		subticks = lib.BigIntRoundToMultiple(
 			subticks,

protocol/x/vault/keeper/orders_test.go

@@ -817,6 +817,21 @@ func TestGetVaultClobOrders(t *testing.T) {
 			perpetual:                  constants.BtcUsd_0DefaultFunding_10AtomicResolution,
 			expectedErr:                vaulttypes.ErrNonPositiveEquity,
 		},
+		"Error - Market price is zero": {
+			vaultParams:                vaulttypes.DefaultParams(),
+			vaultId:                    constants.Vault_Clob_0,
+			vaultAssetQuoteQuantums:    big.NewInt(1_000_000_000), // 1,000 USDC
+			vaultInventoryBaseQuantums: big.NewInt(0),
+			clobPair:                   constants.ClobPair_Btc,
+			marketParam:                constants.TestMarketParams[0],
+			marketPrice: pricestypes.MarketPrice{
+				Id:       0,
+				Exponent: -5,
+				Price:    0,
+			},
+			perpetual:   constants.BtcUsd_0DefaultFunding_10AtomicResolution,
+			expectedErr: vaulttypes.ErrZeroMarketPrice,
+		},
 	}
 
 	for name, tc := range tests {

protocol/x/vault/types/errors.go

@@ -85,4 +85,9 @@ var (
 		16,
 		"TotalShares does not match sum of OwnerShares",
 	)
+	ErrZeroMarketPrice = errorsmod.Register(
+		ModuleName,
+		17,
+		"MarketPrice is zero",
+	)
 )