[TRA-513] Deprecate exchange config json and min exchanges (#2524)

dydxprotocol · Oct 28, 2024 · 338f1ce · 338f1ce
1 parent 4ccfe2b
commit 338f1ce
Show file tree

Hide file tree

Showing 20 changed files with 94 additions and 554 deletions.
diff --git a/indexer/packages/v4-protos/src/codegen/dydxprotocol/prices/market_param.ts b/indexer/packages/v4-protos/src/codegen/dydxprotocol/prices/market_param.ts
@@ -19,7 +19,7 @@ export interface MarketParam {
    * represents ``$10,000`. Therefore `10 ^ Exponent` represents the smallest
    * price step (in dollars) that can be recorded.
    * 
-   * Deprecated since v7.1.x. This value is now determined from the marketmap.
+   * Deprecated since v8.x. This value is now determined from the marketmap.
    */
 
   /** @deprecated */
@@ -28,6 +28,8 @@ export interface MarketParam {
   /**
    * The minimum number of exchanges that should be reporting a live price for
    * a price update to be considered valid.
+   * 
+   * Deprecated since v8.x. This value is now determined from the marketmap.
    */
 
   minExchanges: number;
@@ -40,6 +42,8 @@ export interface MarketParam {
   /**
    * A string of json that encodes the configuration for resolving the price
    * of this market on various exchanges.
+   * 
+   * Deprecated since v8.x. This is now determined from the marketmap.
    */
 
   exchangeConfigJson: string;
@@ -63,7 +67,7 @@ export interface MarketParamSDKType {
    * represents ``$10,000`. Therefore `10 ^ Exponent` represents the smallest
    * price step (in dollars) that can be recorded.
    * 
-   * Deprecated since v7.1.x. This value is now determined from the marketmap.
+   * Deprecated since v8.x. This value is now determined from the marketmap.
    */
 
   /** @deprecated */
@@ -72,6 +76,8 @@ export interface MarketParamSDKType {
   /**
    * The minimum number of exchanges that should be reporting a live price for
    * a price update to be considered valid.
+   * 
+   * Deprecated since v8.x. This value is now determined from the marketmap.
    */
 
   min_exchanges: number;
@@ -84,6 +90,8 @@ export interface MarketParamSDKType {
   /**
    * A string of json that encodes the configuration for resolving the price
    * of this market on various exchanges.
+   * 
+   * Deprecated since v8.x. This is now determined from the marketmap.
    */
 
   exchange_config_json: string;

diff --git a/proto/dydxprotocol/prices/market_param.proto b/proto/dydxprotocol/prices/market_param.proto
@@ -19,11 +19,13 @@ message MarketParam {
   // represents ``$10,000`. Therefore `10 ^ Exponent` represents the smallest
   // price step (in dollars) that can be recorded.
   //
-  // Deprecated since v7.1.x. This value is now determined from the marketmap.
+  // Deprecated since v8.x. This value is now determined from the marketmap.
   sint32 exponent = 3 [ deprecated = true ];
 
   // The minimum number of exchanges that should be reporting a live price for
   // a price update to be considered valid.
+  //
+  // Deprecated since v8.x. This value is now determined from the marketmap.
   uint32 min_exchanges = 4;
 
   // The minimum allowable change in `price` value that would cause a price
@@ -32,5 +34,7 @@ message MarketParam {
 
   // A string of json that encodes the configuration for resolving the price
   // of this market on various exchanges.
+  //
+  // Deprecated since v8.x. This is now determined from the marketmap.
   string exchange_config_json = 6;
 }
diff --git a/protocol/app/ante/market_update_test.go b/protocol/app/ante/market_update_test.go
@@ -265,12 +265,10 @@ var (
 	}
 
 	testMarketParams = prices_types.MarketParam{
-		Id:                 0,
-		Pair:               "TESTING-USD",
-		Exponent:           -8,
-		MinExchanges:       1,
-		MinPriceChangePpm:  10,
-		ExchangeConfigJson: `{"test_config_placeholder":{}}`,
+		Id:                0,
+		Pair:              "TESTING-USD",
+		Exponent:          -8,
+		MinPriceChangePpm: 10,
 	}
 )
 

diff --git a/protocol/daemons/pricefeed/client/types/price_feed_mutable_market_configs_test.go b/protocol/daemons/pricefeed/client/types/price_feed_mutable_market_configs_test.go
@@ -3,9 +3,10 @@ package types_test
 import (
 	"errors"
 	"fmt"
-	"github.com/dydxprotocol/v4-chain/protocol/testutil/daemons/pricefeed"
 	"testing"
 
+	"github.com/dydxprotocol/v4-chain/protocol/testutil/daemons/pricefeed"
+
 	"github.com/dydxprotocol/v4-chain/protocol/daemons/pricefeed/client/types"
 	"github.com/dydxprotocol/v4-chain/protocol/mocks"
 	"github.com/dydxprotocol/v4-chain/protocol/testutil/constants"
@@ -199,31 +200,6 @@ func TestValidateAndTransformParams_Mixed(t *testing.T) {
 			expectedMutableMarketConfigs:   testEmptyMarketConfigs,
 			expectedMutableExchangeConfigs: testEmptyExchangeMarketConfigs,
 		},
-		"Invalid: invalid exchangeConfigJson (empty, fails marketParams.Validate)": {
-			marketParams: []prices_types.MarketParam{{
-				Id:                 1,
-				Exponent:           -2,
-				Pair:               "BTC-USD",
-				MinExchanges:       1,
-				MinPriceChangePpm:  1,
-				ExchangeConfigJson: "",
-			}},
-			expectedMarketParamErrors: map[types.MarketId]error{
-				1: errors.New("ExchangeConfigJson string is not valid"),
-			},
-			expectedMutableMarketConfigs:   testEmptyMarketConfigs,
-			expectedMutableExchangeConfigs: testEmptyExchangeMarketConfigs,
-		},
-		"Invalid: invalid exchangeConfigJson (not json, fails marketParams.Validate)": {
-			marketParams: []prices_types.MarketParam{
-				validMarketParamWithExchangeConfig("invalid"),
-			},
-			expectedMarketParamErrors: map[types.MarketId]error{
-				1: errors.New("ExchangeConfigJson string is not valid"),
-			},
-			expectedMutableMarketConfigs:   testEmptyMarketConfigs,
-			expectedMutableExchangeConfigs: testEmptyExchangeMarketConfigs,
-		},
 		"Invalid: invalid exchangeConfigJson (does not conform to schema)": {
 			marketParams: []prices_types.MarketParam{
 				validMarketParamWithExchangeConfig(`{"exchanges":"invalid"}`),