Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal renovate config. #672

Merged
merged 1 commit into from
May 8, 2024

Conversation

lozette
Copy link

@lozette lozette commented Dec 22, 2023

Inspired by @jkempster34:

The internal renovate config automatically merges minor updates compared to the standard configuration which only merges patches.

As we struggle to keep on top of renovate merges in this repo, I propose we use the internal config here for minor updates.

@yndajas
Copy link
Member

yndajas commented Jan 2, 2024

So I think we're using the non-internal work internal one here since the repo is meant to be ready for client work, and minor updates are more likely to cause unexpected headaches, but it would cut down on maintenance 🤔

@lozette
Copy link
Author

lozette commented Jan 3, 2024

So I think we're using the non-internal work internal one here since the repo is meant to be ready for client work, and minor updates are more likely to cause unexpected headaches, but it would cut down on maintenance 🤔

Yeah I can see both sides tbh. I'm just aware this repo is often neglected! Happy to discuss with others.

@lozette
Copy link
Author

lozette commented Jan 11, 2024

Yikes let's hold off this until we tweak the config dxw/dfsseta-apply-for-landing-ruby#109

@lozette lozette marked this pull request as draft January 11, 2024 11:28
@jdudley1123 jdudley1123 marked this pull request as ready for review May 7, 2024 15:05
Inspired by @jkempster34:

The internal renovate config automatically merges minor updates compared to the
standard configuration which only merges patches.

As we struggle to keep on top of renovate merges in this repo, I propose we use
the internal config here for minor updates.
@jdudley1123 jdudley1123 force-pushed the feature/use-internal-renovate-config branch from a8d5dab to 0dbe80c Compare May 7, 2024 15:05
@jdudley1123 jdudley1123 self-requested a review May 7, 2024 15:05
@jkempster34
Copy link

jkempster34 commented May 7, 2024

Yikes let's hold off this until we tweak the config dxw/dfsseta-apply-for-landing-ruby#109

We had issues on the dfsseta project where dependencies were being merged despite CI failing. That was because because that project had no branch rules configured, but this one does so should be fine 🤞

@jdudley1123 jdudley1123 requested review from yndajas and jkempster34 May 8, 2024 09:01
@jdudley1123 jdudley1123 merged commit ea5bf12 into develop May 8, 2024
2 checks passed
@jdudley1123 jdudley1123 deleted the feature/use-internal-renovate-config branch May 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants