Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including hub server for integration tests #14

Closed
wants to merge 11 commits into from
Closed

Conversation

th0mas
Copy link
Collaborator

@th0mas th0mas commented Aug 6, 2020

Includes the features detailed in #13

@th0mas th0mas changed the title #13 - Including hub server for integration tests Including hub server for integration tests Aug 6, 2020
@th0mas th0mas linked an issue Aug 6, 2020 that may be closed by this pull request
4 tasks
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #14 into master will increase coverage by 1.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   58.82%   60.29%   +1.47%     
==========================================
  Files          12       12              
  Lines         136      136              
==========================================
+ Hits           80       82       +2     
+ Misses         56       54       -2     
Impacted Files Coverage Δ
lib/smart_home_firmware/client/hub_client.ex 72.91% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd65581...f3e96ed. Read the comment docs.

.travis.yml Show resolved Hide resolved
@nelsonic
Copy link
Member

nelsonic commented Aug 7, 2020

@th0mas hopefully you can use the Heroku version of the Hub/Auth server dwyl/smart-home-auth-server#19 for this. 🤞

@th0mas
Copy link
Collaborator Author

th0mas commented Aug 19, 2020

Fixed in an alternative way in dwyl/smart-home-auth-server#14

@th0mas th0mas closed this Aug 19, 2020
@nelsonic
Copy link
Member

@th0mas a lot of the detail in this PR is not captured anywhere and you spent a decent chunk of time exploring it.
If we ever need to run multiple apps on Travis-CI again, it could be worth having this documented somewhere.
e.g: a run-multiple-apps.md in https://github.com/dwyl/learn-travis 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including Hub Server for integration tests
2 participants