Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with event handling descriptions #260 #260

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

MikeRund
Copy link
Contributor

I feel this would help a first time learner (like myself) understand how the logic is being called

I feel this would help a first time learner (like myself) understand how the logic is being called
@MikeRund MikeRund changed the title Update README.md with event handling descriptions Update README.md with event handling descriptions #260 Oct 15, 2024
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeRund these are good additions. 👌
Only feedback is: break up these super-long-lines into easy to read/maintain lines.
Please read: dwyl/style-guide#9

Added line breaks to improve readability of the new descriptions of event handling added in this PR
Copy link
Contributor Author

@MikeRund MikeRund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added line breaks to new description paragraphs

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😍 Thanks @MikeRund 🙌

@nelsonic nelsonic merged commit 1afadd8 into main Oct 16, 2024
2 checks passed
@nelsonic nelsonic deleted the MikeRund-patch-1 branch October 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants