Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Removing "type: module" and bundling .mjs files. #416

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

LuchoTurtle
Copy link
Member

fixes #411

Removes the "type": "module" from package.jsonand subsequently bundles the project into.jsand.mjs files (cjsandesm, respectively), accommodating Javascript projects that are CommonJS`-based.

Accommodates older CommonJS-based `js` projects by removing `type: "module"` from `package.json`.
@LuchoTurtle
Copy link
Member Author

@nelsonic please approve. After approval, I'll publish the new 6.0.2 version and merge this into the main branch.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle LGTM 👌

@nelsonic nelsonic merged commit 3c2d8ad into main Jun 4, 2024
10 checks passed
@nelsonic nelsonic deleted the not-defined-fix#411 branch June 4, 2024 14:29
@nelsonic
Copy link
Member

nelsonic commented Jun 4, 2024

Derp. Was too excited and merged. 🙃
Please publish with the latest SDK: #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6.0.1 broken with TypeError: AWS.mock is not a function
2 participants