Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update Package Version issue #287 #365

Merged
merged 4 commits into from
Jan 23, 2024
Merged

PR: Update Package Version issue #287 #365

merged 4 commits into from
Jan 23, 2024

Conversation

nelsonic
Copy link
Member

Quick PR to release new version of package. #287

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality chore a tedious but necessary task often paying technical debt technical A technical issue that requires understanding of the code, infrastructure or dependencies T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. labels Jan 23, 2024
@nelsonic nelsonic self-assigned this Jan 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ed3004) 100.00% compared to head (8cc3ad2) 100.00%.
Report is 3 commits behind head on main.

❗ Current head 8cc3ad2 differs from pull request most recent head 0514ef0. Consider uploading reports for the commit 0514ef0 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          141       141           
=========================================
  Hits           141       141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nelsonic nelsonic mentioned this pull request Jan 23, 2024
Closed
1 task
@nelsonic nelsonic assigned asntc and unassigned nelsonic Jan 23, 2024
asntc
asntc approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@asntc asntc merged commit b356ef6 into main Jan 23, 2024
10 checks passed
@nelsonic nelsonic deleted the update-package-version-issue-#287 branch January 23, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asntc asntc asntc approved these changes

Assignees

@asntc asntc

Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Nelson's List
Status: Done
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @asntc