This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Support for nullable error_bag #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Logically, is this different from #95? I can’t remember where we got to with this issue, I thought that PR was made available for testing to see if it resolved the issue and I never heard anything. But looking at the code on this PR it seems functionally the same as my earlier PR. |
|
Yeah, basically the same, but it was not yet added to any release? |
|
It wasn't merged because I asked in the ticket if anyone could test it and confirm that it resolved the issue - didn't want to bring it in if it didn't do the trick. If you're saying it works then I'll bring the old PR up to date and merge it in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #86