Update RTD config

[dwhswenson]

Apparently docs were not building correctly, and furthermore, we had some setting to use system packages, which will no longer be allowed.

Let's get that fixed.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (3ae38ea) 100.00% compared to head (f01af32) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1154      1154           
=========================================
  Hits          1154      1154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sroet]

1 unnecessary line seems to be added, otherwise LGTM

[dwhswenson]

NB: this is still failing in RTD, so it needs some more work. @sroet : I noticed that you aren't listed as a maintainer with RTD; an oversight because I so rarely need to log into the RTD interface. Do you use the same username over there?

[sroet]

Do you use the same username over there?

I do

[sroet]

LGTM, feel free to merge if this works on RTD

[sroet]

our builds seem to hit sphinx-contrib/napoleon#9 which became breaking in python 3.10+ not sure why that is still an issue when it became packaged with sphinx

EDIT: it seems like RTD is pulling in sphinx<2 in the line

python -m pip install --upgrade --no-cache-dir pillow mock==1.0.1 alabaster>=0.7,<0.8,!=0.7.5 commonmark==0.9.1 recommonmark==0.5.0 sphinx<2 sphinx-rtd-theme<0.5 readthedocs-sphinx-ext<2.3 jinja2<3.1.0

I think for now the easiest solution is to run python 3.9 for the doc builds

[sroet]

Seems like that build passed, feel free to merge!

[dwhswenson]

Yep, looks like 3.9 was enough!

The sphinx<2 is because older projects have some ancient defaults. (I think we started in October 2017). I think we may need to eventually update docs/rtd_requirements.txt to ask for more recent versions, but this works for now!