Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CB2-12693): Implement types-definition into retro-gen service #124

Merged
merged 11 commits into from
Jul 15, 2024
Merged

feat(CB2-12693): Implement types-definition into retro-gen service #124

merged 11 commits into from
Jul 15, 2024

Conversation

Daniel-Searle
Copy link
Contributor

@Daniel-Searle Daniel-Searle commented Jul 4, 2024 •
edited
Loading

Implement types-definition into retro-gen service

Utilised the types definition types and removed the existing types
CB2-12693

Checklist

  • Branch is rebased against the latest develop
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Link to the PR added to the repo

@Daniel-Searle Daniel-Searle changed the title feat(CB2-12693): added type definition types feat(CB2-12693): Implement types-definition into retro-gen service Jul 4, 2024
@Daniel-Searle Daniel-Searle marked this pull request as ready for review July 4, 2024 11:48
cb-cs
cb-cs reviewed Jul 8, 2024
View reviewed changes
src/functions/retroGen.ts Outdated Show resolved Hide resolved
@Daniel-Searle Daniel-Searle requested a review from cb-cs July 8, 2024 13:19
m-coslett
m-coslett reviewed Jul 8, 2024
View reviewed changes
src/services/ActivitiesService.ts Show resolved Hide resolved
src/services/ActivitiesService.ts Outdated Show resolved Hide resolved
src/models/index.d.ts Show resolved Hide resolved
src/services/RetroGenerationService.ts Outdated Show resolved Hide resolved
@Daniel-Searle Daniel-Searle requested a review from cb-cs July 9, 2024 10:23
m-mullen
m-mullen previously approved these changes Jul 9, 2024
View reviewed changes
cb-cs
cb-cs reviewed Jul 10, 2024
View reviewed changes
src/models/index.d.ts Outdated Show resolved Hide resolved
@Daniel-Searle Daniel-Searle requested a review from cb-cs July 10, 2024 13:10
cb-cs
cb-cs previously approved these changes Jul 10, 2024
View reviewed changes
m-mullen
m-mullen previously approved these changes Jul 10, 2024
View reviewed changes
@Daniel-Searle Daniel-Searle dismissed stale reviews from m-mullen and cb-cs July 15, 2024 09:00

The merge-base changed after approval.

@Daniel-Searle Daniel-Searle merged commit db5610a into develop Jul 15, 2024
4 of 5 checks passed
@Daniel-Searle Daniel-Searle deleted the feature/CB2-12693 branch July 15, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-cs cb-cs cb-cs approved these changes

@m-mullen m-mullen m-mullen approved these changes

@m-coslett m-coslett Awaiting requested review from m-coslett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daniel-Searle @m-coslett @cb-cs @m-mullen