Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTA-1575: Generate Welsh certificate Trailer - Pass #90

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

m-coslett
Copy link
Contributor

@m-coslett m-coslett commented Sep 19, 2023

Generate Welsh certificate Trailer - Pass

Made all changes required to allow a new document/pdf type to be generated, trl_pass_bilingual - which consists of both a VTG5A and VTG5AW certificate should the test station associated with the passed trl test result reside in Wales.

Related issue: VTA-1575

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@m-coslett m-coslett marked this pull request as ready for review September 22, 2023 12:15
@cb-cs cb-cs merged commit fbc5dfe into feature/VTAWELSH-1 Sep 25, 2023
5 checks passed
@cb-cs cb-cs deleted the feature/VTA-1575 branch September 25, 2023 13:20
cb-cs pushed a commit that referenced this pull request Oct 16, 2023
* feat(vta-1575): welsh certificate for trailer pass

* feat(vta-1575): corrected data model on welsh trailer cert

* feat(vta-1575): identification number not registration number

* feat(vta-1575): regid or heading welsh

* feat(vta-1575): corrected regid or heading in bilingual model
cb-cs pushed a commit that referenced this pull request Dec 15, 2023
* feat(vta-1575): welsh certificate for trailer pass

* feat(vta-1575): corrected data model on welsh trailer cert

* feat(vta-1575): identification number not registration number

* feat(vta-1575): regid or heading welsh

* feat(vta-1575): corrected regid or heading in bilingual model
@cb-cs cb-cs mentioned this pull request Jan 12, 2024
4 tasks
cb-cs added a commit that referenced this pull request Jan 22, 2024
* feat(vta-1618): duplicated appropriate templates ready for welsh conversion (#87)

feat(vta-1618): added failWelsh template

feat(vta-1618): added passNoSeatbeltFieldsWelsh template

feat(vta-1618): added passWelsh template

feat(vta-1618): added VTG30Welsh template

* VTA-1574: Generate Welsh Certificate HGV Pass (#88)

* feat(vta-1574): added models and updated logic to use vtg5 bilingual

* feat(vta-1574): updated naming convention so it makes more sense

* feat(vta-1574): added html verification test for vtg5

* feat(vta-1574): added tests for VTG5W

* feat(vta-1574): added tests for hgv pass bilingual

* feat(vta-1574): updated unit tests

* feat(vta-1574): refactored naming convention for statics

* feat(vta-1574): added welsh crest logo to passNoSeatbelts hbs

* feat(vta-1574): refactored unit tests, added welsh mileage translation

* feat(vta-1574): applied welsh miles logic to odometer history

* feat(vta-1574): refactored static

* VTA-1575: Generate Welsh certificate Trailer - Pass (#90)

* feat(vta-1575): welsh certificate for trailer pass

* feat(vta-1575): corrected data model on welsh trailer cert

* feat(vta-1575): identification number not registration number

* feat(vta-1575): regid or heading welsh

* feat(vta-1575): corrected regid or heading in bilingual model

* VTA-1576: Generate Welsh Certificate PSV Pass (#92)

* feat(vta-1576): added new models, updated enums and configs

* feat(vta-1576): corrected typo

* feat(vta-1576): added new tests

* feat(vta-1576): corrected formatting

* feat(cb2-9560): rebased against develop and removed loggers

* feat(cb2-9560): added logger for debug

* feat(cb2-9560): removed loggers used for debug

* CB2-9558: updated no data available, km and mi translations (#94)

* feat(cb2-9558): updated no data available, km and mi translations

* feat(cb2-9558): corrected typo on statics

* feat(cb2-9558): updated translation as per feedback

---------

Co-authored-by: Melanie Coslett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants