feat(cb2-10900): Add Front Page to IVA30 #104

m-mullen · 2024-02-12T11:24:39Z

Description

Added HTML/CSS to IVA30 handlebars in anticipation for recieving data.

Related issue: [CB2-10900] https://dvsa.atlassian.net/browse/CB2-10900

Before submitting (or marking as "ready for review")

Does the pull request title follow the conventional commit specification?
Have you performed a self-review of the code
Have you have added tests that prove the fix or feature is effective and working
Did you make sure to update any documentation relating to this change?

src/main/java/uk/gov/dvsa/PdfGenerator.java

src/main/java/uk/gov/dvsa/model/cvs/AdrPassCertificate.java

feat(cb2-10900): Removing TODOs, code formatting, replace link with hyperlink feat(cb2-10900): remove loggers

cb-cs · 2024-02-14T09:38:33Z

src/main/resources/views/CommercialVehicles/IVA30.hbs

@@ -1,131 +1,236 @@
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">


Missing DVSA logo top right hand side of generated certificate.

Odd, should be there. Line 23

src/main/resources/views/CommercialVehicles/IVA30.hbs

m-coslett

Basic test example.pdf

there are some differences to the current cert (attached here) that need to be addressed:

Grey shading in all heading sections looks too dark
The text under the first heading box, starting with 'an appointment for re-exam...' needs to be centered
'Reapplication required by' section is too far left, this should start in the centre of the page. Same applies to Date and Station boxes
The footer info (IVA30VTA etc.) should be in the document footer, not floating
The page number is missing from the last page
DVSA logo is missing

cb-cs · 2024-02-19T11:09:37Z

Some further comments on the latest/updated PR 19/02/2024.
-- appears to need to be a little more spacing underneath all boxes including Serial Number, Vehicle/Trailer NR No, Test Category/ Class, Make/Model, Body Type, VIN/Chassic No, Reguired Standard(s) Not Met, Signed, Name, Date, Station, Reapplicaton Date. All box headings. The original doc appears to be justified vertically for these input boxes.
-- 'The Road Vehicles (Approval) Regulations 2020' appears to be smaller font in original doc
-- missing the 'is' in YOUR RIGHT TO APPEAL change, should read 'no modification/rectification work is carried out...'

Would also be really good to see one of these generated when they are populated, even if you have to use dummy / hardcoded data to test.

Daniel-Searle · 2024-02-19T10:56:55Z

src/main/resources/assets/stylesheets/iva-30.hbs

 .section-border {
 border-style: solid;
-border-color: black grey grey grey;
+border-color: black black black black;


no need to have the colour multiple times

m-coslett

No need for capitals on ‘Required by’ after ‘Reapplication’
Capitalisation wrong in text under signature section ‘The Following additional defects…’
IVA17 should be underlined in appeal section
'received' spelt wrong in appeal section
missing ‘is’ in last sentence of appeal section

* feat(cb2-9866): rebased and added logger * feat(cb2-10900): IVA30 front page html/css feat(cb2-10900): Removing TODOs, code formatting, replace link with hyperlink feat(cb2-10900): remove loggers * feat(cb2-9866): rebased and added logger * feat(cb2-10900): remove loggers * feat(cb2-10900): Correcting formatting and dynamic footer * feat(cb2-10900): correct stylesheet * feat(cb2-10900): back page text matches new format * feat(cb2-10900): Fix dvsa logo * feat(cb2-10900): Fix dvsa logo * feat(cb2-10900): correct document margins * feat(cb2-10900): correcting margin correction * feat(cb2-10900): css error * feat(cb2-10900): css error fix again * feat(cb2-10900): Removing excess blank page * feat(cb2-10900): test if blank page still created * feat(cb2-10900): fix the test if blank page still created * feat(cb2-10900): Remove back-page page break * feat(cb2-10900): Remove back-page page break * feat(cb2-10900): Test dynamic paging * feat(cb2-10900): Remove test data * feat(cb2-10900): hard text corrections * feat(cb2-10900): hard text corrections * feat(cb2-10900): table formatting and test data * feat(cb2-10900): table formatting and test data * feat(cb2-10900): test data * feat(cb2-10900): remove test data * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header formatting * feat(cb2-10900): dynamic header formatting * feat(cb2-10900): dynamic header formatting image * feat(cb2-10900): dynamic header margin size * feat(cb2-10900): dynamic header margin size * feat(cb2-10900): Dynamic header implemented --------- Co-authored-by: Craig Broady <[email protected]>

* feat(cb2-10900): Add Front Page to IVA30 (#104) * feat(cb2-9866): rebased and added logger * feat(cb2-10900): IVA30 front page html/css feat(cb2-10900): Removing TODOs, code formatting, replace link with hyperlink feat(cb2-10900): remove loggers * feat(cb2-9866): rebased and added logger * feat(cb2-10900): remove loggers * feat(cb2-10900): Correcting formatting and dynamic footer * feat(cb2-10900): correct stylesheet * feat(cb2-10900): back page text matches new format * feat(cb2-10900): Fix dvsa logo * feat(cb2-10900): Fix dvsa logo * feat(cb2-10900): correct document margins * feat(cb2-10900): correcting margin correction * feat(cb2-10900): css error * feat(cb2-10900): css error fix again * feat(cb2-10900): Removing excess blank page * feat(cb2-10900): test if blank page still created * feat(cb2-10900): fix the test if blank page still created * feat(cb2-10900): Remove back-page page break * feat(cb2-10900): Remove back-page page break * feat(cb2-10900): Test dynamic paging * feat(cb2-10900): Remove test data * feat(cb2-10900): hard text corrections * feat(cb2-10900): hard text corrections * feat(cb2-10900): table formatting and test data * feat(cb2-10900): table formatting and test data * feat(cb2-10900): test data * feat(cb2-10900): remove test data * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header pagination * feat(cb2-10900): dynamic header formatting * feat(cb2-10900): dynamic header formatting * feat(cb2-10900): dynamic header formatting image * feat(cb2-10900): dynamic header margin size * feat(cb2-10900): dynamic header margin size * feat(cb2-10900): Dynamic header implemented --------- Co-authored-by: Craig Broady <[email protected]> * feat(cb2-9866): rebased and added logger (#108) feat(cb2-10900): IVA30 front page html/css feat(cb2-10900): Removing TODOs, code formatting, replace link with hyperlink feat(cb2-10900): remove loggers feat(cb2-9866): rebased and added logger feat(cb2-10900): remove loggers feat(cb2-10900): Test dynamic paging feat(cb2-10900): Remove test data feat(cb2-9976): updated models, added to handlebars to test feat(cb2-9976): update model feat(cb2-9976): added zero value constructor feat(cb2-9976): updated model feat(cb2-9976): fixed typo feat(cb2-9976): updated format feat(cb2-9976): updated format feat(cb2-9976): updating additionalDefects key feat(cb2-9976): camelCased properties coming in as part of payload feat(cb2-9976): set up initial pdfVerification test feat(cb2-9976): started IVA30 unit test feat(cb2-9976): updated additional defect model feat(cb2-9976): ignore unknown feat(cb2-9976): typo correction feat(cb2-9976): first attempt feat(cb2-9976): attempt 2 feat(cb2-9976): corrected field feat(cb2-9976): added new keys to model feat(cb2-9976): added class for lists feat(cb2-9976): added capitalise and bold for section feat(cb2-9976): added new paragraph feat(cb2-9976): added uppercase feat(cb2-9976): test formatting feat(cb2-9976): commented out tests for deployment feat(cb2-9976): reverted test provider feat(cb2-9976): removed comments in .hbs that was causing issues feat(cb2-9976): added line break feat(cb2-9976): added if to additional notes feat(cb2-9976): updated feat(cb2-9976): updated pdf verification tests feat(cb2-9976): set up html verification tests feat(cb2-9976): added tests for coverage feat(cb2-9976): added tests for rs feat(cb2-9976): additional defect tests feat(cb2-9976): tidied up tests feat(cb2-9976): updated naming convention in hbs class feat(cb2-9976): updated enums feat(cb2-9976): naming convention feat(cb2-9976): corrected formatting feat(cb2-9976): changed rs number to int feat(cb2-9976): updated date format to reflect payload feat(cb2-9976): reverted test --------- Co-authored-by: m-mullen <[email protected]>

m-mullen changed the title ~~feat(10900): Add Front Page to IVA30~~ feat(cb2-10900): Add Front Page to IVA30 Feb 12, 2024

LGin-BJSS reviewed Feb 12, 2024

View reviewed changes

src/main/java/uk/gov/dvsa/PdfGenerator.java Outdated Show resolved Hide resolved

LGin-BJSS reviewed Feb 12, 2024

View reviewed changes

src/main/java/uk/gov/dvsa/model/cvs/AdrPassCertificate.java Outdated Show resolved Hide resolved

cb-cs and others added 4 commits February 13, 2024 10:40

feat(cb2-9866): rebased and added logger

ad6cc84

feat(cb2-10900): IVA30 front page html/css

21c18ea

feat(cb2-10900): Removing TODOs, code formatting, replace link with hyperlink feat(cb2-10900): remove loggers

feat(cb2-9866): rebased and added logger

4022f50

feat(cb2-10900): remove loggers

60c53e8

m-mullen force-pushed the feature/CB2-10900 branch from 2fea11a to 60c53e8 Compare February 13, 2024 13:59