Feature/pathfinding #21
Conversation
…rbe/SVENSimulation into feature/Pathfinding
This reverts commit 1554a32.
| using UnityEngine; | ||
|
|
||
| namespace Assets.Scripts.Pathfinding | ||
| { | ||
| public sealed class Edge | ||
| { | ||
| public Edge(Vertex target, float cost) | ||
| public Edge(Vertex target, Vertex start, float cost) |
Assets/Scripts/Pathfinding/Edge.cs
Outdated
| Vector2 directionVectorScondeEdge = endPoint - startPoint; | ||
|
|
||
|
|
||
| float t1; // aus x = p0 + t * a (x p0 und a sind Vektoren) |
Assets/Scripts/Pathfinding/Edge.cs
Outdated
| float t1; // aus x = p0 + t * a (x p0 und a sind Vektoren) | ||
| float t2; | ||
|
|
||
| float anstiegScondeEdge; |
There was a problem hiding this comment.
rename variable name to english an remove typo "Sconde" to "Second"
Assets/Scripts/Pathfinding/Edge.cs
Outdated
|
|
||
| //IF Intersection bestimmen | ||
| //kontrolle auf paralelität | ||
| if ( Math.Abs(anstiegScondeEdge) == Math.Abs(_anstieg)) |
There was a problem hiding this comment.
rename _anstieg to english name
Added comment
Assets/Scripts/Pathfinding/Edge.cs
Outdated
| } | ||
| else | ||
| { | ||
| if (_directionVector.y == 0) |
There was a problem hiding this comment.
floating point numbers are not directly compared to another floating point value
use Epsilon Neighbourhood (https://en.wikipedia.org/wiki/Neighbourhood_(mathematics))
possible implementation:
if (Mathf.Abs(_directionVector.y) < 0.01)
Assets/Scripts/Pathfinding/Edge.cs
Outdated
| { | ||
| if (_directionVector.y == 0) | ||
| { | ||
| throw new Exception("Direction Vektor is null Vektor!!"); |
There was a problem hiding this comment.
Translate Exception Message to english
Assets/Scripts/Pathfinding/Vertex.cs
Outdated
| @@ -14,13 +14,15 @@ protected Vertex(Vector2 position) | |||
| Position = position; | |||
| } | |||
|
|
|||
| public Vector2 Position { get; } | |||
| public UnityEngine.Vector2 Position { get; } | |||
Changed UnityEngine.Vector2 to Vector2
| @@ -242,12 +251,38 @@ void Start() | |||
| } | |||
| } | |||
| } | |||
| #endregion | |||
|
|
|||
| #region WallVertexFüttern | |||
|
|
||
| #endregion | ||
|
|
||
| #region RoomObjects Creator | ||
|
|
||
| foreach(RoomObjects obj in roomObjects) | ||
| foreach (RoomObjects obj in roomObjects) |
There was a problem hiding this comment.
why not rename variable obj to roomObject? This whould clear up the meaning what this variable does.
There was a problem hiding this comment.
Rename class RoomObjects to RoomObject, becuase one instance just stores one object and not multiple. Name would imply that one instance can store multiple objects.
| @@ -256,8 +291,8 @@ void Start() | |||
| roomObject = Instantiate( | |||
| _chairPrefab, //the GameObject that will be instantiated | |||
| position: new Vector3( | |||
| x: (WallThickness + obj.PosY) + 0.5f, | |||
| y: (WallThickness + obj.PosX) + 0.5f), | |||
| x: (WallThickness + obj.PosX) + 0.5f, | |||
There was a problem hiding this comment.
Rename PosX to "PositionX" or "XPosition" and PosY to "PositionY" or "YPosition" to clear up the meaning of the variable
| { | ||
| get | ||
| { | ||
| return Rotation * Math.PI / 180; |
There was a problem hiding this comment.
Use Mathf.PI instead. It takes time for the cpu to switch between the floting point precision double and float an to convert double to float
… thermodynamics) overheating problem
…onal RoomElementType Tablet
Look what we've done!